fix(Checkbox/RadioGroup): add flex-wrap on list and card variants - #6913
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe checkbox group and radio group fieldset classes now include Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change enables checkbox and radio items to wrap in narrow containers, addressing overflow without an identified merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
The new base flex-wrap can interact incorrectly with the table variant’s -space-x-px/-space-y-px border-collapsing layout, potentially causing overlap artifacts when wrapping occurs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the default styling for CheckboxGroup and RadioGroup so their internal fieldset can wrap, preventing option overflow in narrow containers. It also refreshes related test snapshots and bumps the Nuxt test-utils setup version used by the test harness.
Changes:
- Add
flex-wrapto thefieldsetslot styling insrc/theme/checkbox-group.tsandsrc/theme/radio-group.ts. - Update Vitest snapshot outputs for CheckboxGroup/RadioGroup to reflect the new
fieldsetclass list. - Bump
@nuxt/test-utilssetup version intest/nuxt/.nuxtrc.
File summaries
| File | Description |
|---|---|
| test/nuxt/.nuxtrc | Updates Nuxt test-utils setup version used in tests. |
| test/components/snapshots/RadioGroup.spec.ts.snap | Snapshot updates reflecting added flex-wrap on the rendered fieldset. |
| test/components/snapshots/RadioGroup-vue.spec.ts.snap | Snapshot updates reflecting added flex-wrap on the rendered fieldset (Vue playground variant). |
| test/components/snapshots/CheckboxGroup.spec.ts.snap | Snapshot updates reflecting added flex-wrap on the rendered fieldset. |
| test/components/snapshots/CheckboxGroup-vue.spec.ts.snap | Snapshot updates reflecting added flex-wrap on the rendered fieldset (Vue playground variant). |
| src/theme/radio-group.ts | Adds flex-wrap to the fieldset slot theme classes. |
| src/theme/checkbox-group.ts | Adds flex-wrap to the fieldset slot theme classes. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
commit: |
374d6b1 to
2e4d13f
Compare
flex-wrap on default variantflex-wrap on list and card variants
🔗 Linked issue
Closes #6912
❓ Type of change
Not sure if it should be considered a bug fix or a breaking change.
📚 Description
This PR adds
.flex-wrapto the fieldset element of bothCheckboxGroupandRadioGroup. This improves how the children checkboxes and radios are rendered in narrow containers.Without wrapping, the root element currently ends up overflowing its container.
📝 Checklist