fix(Tree): remove value-key in favor of get-key#4999
Merged
benjamincanac merged 11 commits intov4from Sep 18, 2025
Merged
Conversation
commit: |
sandros94
changed the title
value and introduce index-key propvalue and introduce get-key prop
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
benjamincanac
changed the title
value and introduce get-key propvalue-key in favor of get-key
docs/app/components/content/examples/tree/TreeExpandedExample.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
benjamincanac
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #3762
❓ Type of change
📚 Description
The type support for Tree commponent was almost completely broken, but more importantly it had the same
valuekey which other components do use to extract a specific value from the object input, butUTreedoesn't actually extract the value, it returns the whole object. What it does require is a unique index for each item in the array, which is customizable viaget-keyprop, that when undefined it falls back tolabel, this should cover for most generic uses of the component, even small improper ones.Intentionally not mentioning this in the v4 migration, as it was broken to begin with in v3.
📝 Checklist