fix(Breadcrumb): show current route as active #5562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issued
Resolves #5513
🙏 Help requested
The fix works as expected in the playground (
pnpm run dev) but I can't make the tests to work. For some reason, passing the route tomountSuspendedis not enough for the test to simulate how Breadcrumb/Link perceives the current route when mounted in the environment. Could you help me into the right direction?❓ Type of change
📚 Description
Currently, if the
activeprop is not set for all breadcrumb items (->item.active), then(index === items!.length - 1)is used to determine whether the item should be shown as active. It is therefore always the last item of the breadcrumb which is shown as active.This PR solves this by making use of the
activeslot prop of the Link component to show the current route as active.📝 Checklist