Skip to content

Comments

fix(CheckboxGroup): update update:modelValue emit type#5927

Merged
benjamincanac merged 2 commits intonuxt:v4from
LouisHaftmann:v4
Jan 26, 2026
Merged

fix(CheckboxGroup): update update:modelValue emit type#5927
benjamincanac merged 2 commits intonuxt:v4from
LouisHaftmann:v4

Conversation

@LouisHaftmann
Copy link
Contributor

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Current type of update:modelValue does not respect the valueKey prop. Only a type change is required since it already uses valueKey at runtime.

@github-actions github-actions bot added the v4 #4488 label Jan 23, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

The PR updates src/runtime/components/CheckboxGroup.vue to change the emits typing. CheckboxGroupEmits now accepts a second generic VK (default 'value') and is redefined to Omit the original root emits' update:modelValue, add a change: [event: Event], and include GetModelValueEmits<T, VK, true>. The component's defineEmits invocation is updated from CheckboxGroupEmits<T> to CheckboxGroupEmits<T, VK>.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating the emit type for update:modelValue in CheckboxGroup to respect the valueKey prop.
Description check ✅ Passed The description is directly related to the changeset, explaining that the PR fixes the type of update:modelValue to respect the valueKey prop, with only type changes needed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 23, 2026

npm i https://pkg.pr.new/@nuxt/ui@5927

commit: f3264ae

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants