Skip to content

Comments

feat(module): add support for taupe / mauve / mist / olive neutral colors#6081

Merged
benjamincanac merged 1 commit intonuxt:v4from
mateusznarowski:feat/add-new-tailwind-neutral-colors
Feb 20, 2026
Merged

feat(module): add support for taupe / mauve / mist / olive neutral colors#6081
benjamincanac merged 1 commit intonuxt:v4from
mateusznarowski:feat/add-new-tailwind-neutral-colors

Conversation

@mateusznarowski
Copy link
Contributor

@mateusznarowski mateusznarowski commented Feb 20, 2026

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Following the release of Tailwind CSS v4.2.0, I have added the new color options to the neutral palette. This change includes:

  • Adding taupe, mauve, mist, and olive to the neutralColors constant in useTheme.
  • Updating the ThemeDropdown component in the playground to support these new options.
  • Updating NeutralColor TypeScript types in src/templates.ts and src/unplugin.ts.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@dosubot
Copy link

dosubot bot commented Feb 20, 2026

Related Documentation

Checked 0 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@github-actions github-actions bot added the v4 #4488 label Feb 20, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 20, 2026

📝 Walkthrough

Walkthrough

This pull request expands the neutral color palette used throughout the theme system. Four new color identifiers—taupe, mauve, mist, and olive—are added to the NeutralColor type definition and corresponding runtime color arrays across four files: the theme composable, the theme dropdown component, and two type/plugin files. The changes are consistent and additive, maintaining existing functionality while broadening the set of available neutral colors.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding support for four new neutral colors (taupe, mauve, mist, olive) to the theme module, which aligns with all file changes across the codebase.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale (Tailwind CSS v4.2.0 release) and detailing all changes made across multiple files including useTheme, ThemeDropdown, and type definitions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/templates.ts (1)

296-297: Extract duplicated NeutralColor type to a shared module.

The NeutralColor type is defined identically in both src/templates.ts (line 296) and src/unplugin.ts (line 27). Any future additions must be updated in two places with no compile-time guard against divergence. Extract to a single shared source:

♻️ Suggested extraction

Create src/types.ts:

+export type NeutralColor = 'slate' | 'gray' | 'zinc' | 'neutral' | 'stone' | 'taupe' | 'mauve' | 'mist' | 'olive'

Then in both src/templates.ts and src/unplugin.ts:

+import type { NeutralColor } from './types'
-type NeutralColor = 'slate' | 'gray' | 'zinc' | 'neutral' | 'stone' | 'taupe' | 'mauve' | 'mist' | 'olive'
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/templates.ts` around lines 296 - 297, Extract the duplicated NeutralColor
union into a single exported type in a new module (e.g., create src/types.ts)
and export NeutralColor so both modules can import it; then remove the local
NeutralColor definition in src/templates.ts and src/unplugin.ts and update the
Color type in each to reference the imported NeutralColor instead of the local
symbol, ensuring imports are added (import { NeutralColor } from 'src/types')
and no other logic is changed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@src/unplugin.ts`:
- Around line 27-28: The NeutralColor union is duplicated; extract the
NeutralColor definition into a single shared type and import it where needed,
then update the local Color type to reference that imported NeutralColor instead
of re-declaring it; specifically remove the duplicate NeutralColor in
unplugin.ts and have the Color type (symbol: Color) use the shared NeutralColor
type (symbol: NeutralColor) so both places share the single canonical
definition.

---

Nitpick comments:
In `@src/templates.ts`:
- Around line 296-297: Extract the duplicated NeutralColor union into a single
exported type in a new module (e.g., create src/types.ts) and export
NeutralColor so both modules can import it; then remove the local NeutralColor
definition in src/templates.ts and src/unplugin.ts and update the Color type in
each to reference the imported NeutralColor instead of the local symbol,
ensuring imports are added (import { NeutralColor } from 'src/types') and no
other logic is changed.

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 😊

@benjamincanac benjamincanac changed the title feat: add taupe, mauve, mist, and olive to neutral color palette feat(module): add support for taupe / mauve / mist / olive neutral colors Feb 20, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 20, 2026

npm i https://pkg.pr.new/@nuxt/ui@6081

commit: 9a93818

@benjamincanac benjamincanac merged commit bc49d3f into nuxt:v4 Feb 20, 2026
18 checks passed
@mateusznarowski mateusznarowski deleted the feat/add-new-tailwind-neutral-colors branch February 20, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants