fix(PricingTable): align header elements vertically#6111
fix(PricingTable): align header elements vertically#6111maximepvrt wants to merge 2 commits intonuxt:v4from
Conversation
📝 WalkthroughWalkthroughThe PricingTable component's template was refactored to introduce a top-level Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/runtime/components/PricingTable.vue`:
- Around line 206-212: Indent the billing slot spans and their inner text by two
additional spaces to satisfy vue/html-indent: locate the elements with
data-slot="tierBillingPeriod" and data-slot="tierBillingCycle" (and their
bindings ui.tierBillingPeriod, ui.tierBillingCycle, tier.billingPeriod,
tier.billingCycle, uiProp?.tierBillingPeriod) and adjust their indentation so
both the <span> lines and their interpolated content are aligned with the parent
slot block (two spaces deeper than currently) to resolve the ESLint failure.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
test/components/__snapshots__/PricingTable-vue.spec.ts.snapis excluded by!**/*.snaptest/components/__snapshots__/PricingTable.spec.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (2)
src/runtime/components/PricingTable.vuesrc/theme/pricing-table.ts
commit: |
Added a
tierWrapperto fix the vertical alignment of elements in the table headers, using anh-0hack on the parent cell to force the wrapper to fill the entire available space.Before
After
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist