Skip to content

fix(ChatShimmer): handle RTL mode#6180

Merged
benjamincanac merged 1 commit intonuxt:v4from
malik-jouda:v4_msh5
Mar 12, 2026
Merged

fix(ChatShimmer): handle RTL mode#6180
benjamincanac merged 1 commit intonuxt:v4from
malik-jouda:v4_msh5

Conversation

@malik-jouda
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the v4 #4488 label Mar 12, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 80f60b85-ea7b-49dc-986e-b7d15f1b4097

📥 Commits

Reviewing files that changed from the base of the PR and between 6db594e and cb1e306.

⛔ Files ignored due to path filters (4)
  • test/components/__snapshots__/ChatReasoning-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/ChatReasoning.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/ChatShimmer-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/ChatShimmer.spec.ts.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • src/runtime/keyframes.css
  • src/theme/chat-shimmer.ts

📝 Walkthrough

Walkthrough

The changes add right-to-left (RTL) language support to chat shimmer animations. A new shimmer-rtl keyframe animation is introduced in the CSS file to mirror the direction of the existing shimmer animation, while the TypeScript theme configuration is updated to apply this RTL variant when needed. Additionally, some CSS transform lines are reformatted to single-line expressions without behavioral changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is a template with no substantive details about the changes, though it indicates a bug fix type was selected. Provide a description explaining why RTL support was needed for ChatShimmer and what the fix accomplishes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding RTL mode support to the ChatShimmer component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 12, 2026

npm i https://pkg.pr.new/@nuxt/ui@6180

commit: 2a15985

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @malik-jouda for always picking up RTL support after me! 😊

@benjamincanac benjamincanac merged commit 51793a8 into nuxt:v4 Mar 12, 2026
16 of 17 checks passed
@malik-jouda malik-jouda deleted the v4_msh5 branch March 13, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants