Skip to content

fix(DashboardSearchButton): use valid HTML structure for trailing slot#6194

Merged
benjamincanac merged 1 commit intonuxt:v4from
caiotarifa:v4
Mar 16, 2026
Merged

fix(DashboardSearchButton): use valid HTML structure for trailing slot#6194
benjamincanac merged 1 commit intonuxt:v4from
caiotarifa:v4

Conversation

@caiotarifa
Copy link
Contributor

🔗 Linked issue

Resolves #6183

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR fixes an invalid HTML structure issue in the DashboardSearchButton component where a block-level <div> was nested inside a <button>.

The <div> in the trailing slot was replaced with a <span>, which is semantically valid phrasing content for buttons.

Zero visual impact (the layout classes remain the same and Tailwind handles the flexbox).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the v4 #4488 label Mar 16, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f33d71ca-e875-4204-a27c-34da9dcfcaf4

📥 Commits

Reviewing files that changed from the base of the PR and between a69baeb and 19fef40.

⛔ Files ignored due to path filters (2)
  • test/components/__snapshots__/DashboardSearchButton-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/DashboardSearchButton.spec.ts.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • src/runtime/components/DashboardSearchButton.vue

📝 Walkthrough

Walkthrough

This change modifies the DashboardSearchButton.vue component by replacing a block-level <div> element with an inline <span> element in the trailing slot container. This adjustment addresses an HTML validity issue where block-level elements should not be nested directly inside button elements. The class bindings, slot content, and overall component behavior remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: replacing a div with a span in the trailing slot to fix invalid HTML structure.
Description check ✅ Passed The description clearly explains the bug fix, references the linked issue, and describes the change from div to span with no visual impact.
Linked Issues check ✅ Passed The PR fully addresses issue #6183 by replacing the block-level div with an inline span element inside the button, resolving the invalid HTML semantics issue.
Out of Scope Changes check ✅ Passed The changes are limited to the single file affected and directly address the scope of issue #6183 with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 16, 2026

npm i https://pkg.pr.new/@nuxt/ui@6194

commit: 19fef40

@benjamincanac benjamincanac merged commit 578a12f into nuxt:v4 Mar 16, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DashboardSearchButton: Invalid HTML structure: <div> inside <button>

2 participants