fix(DashboardSearchButton): use valid HTML structure for trailing slot#6194
fix(DashboardSearchButton): use valid HTML structure for trailing slot#6194benjamincanac merged 1 commit intonuxt:v4from
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change modifies the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
commit: |
🔗 Linked issue
Resolves #6183
❓ Type of change
📚 Description
This PR fixes an invalid HTML structure issue in the
DashboardSearchButtoncomponent where a block-level<div>was nested inside a<button>.The
<div>in the trailing slot was replaced with a<span>, which is semantically valid phrasing content for buttons.Zero visual impact (the layout classes remain the same and Tailwind handles the flexbox).
📝 Checklist