Skip to content

fix(InputTags): add missing field group variant#6326

Merged
benjamincanac merged 1 commit intonuxt:v4from
mateusznarowski:fix/input-tags-field-group-variant
Apr 9, 2026
Merged

fix(InputTags): add missing field group variant#6326
benjamincanac merged 1 commit intonuxt:v4from
mateusznarowski:fix/input-tags-field-group-variant

Conversation

@mateusznarowski
Copy link
Copy Markdown
Contributor

🔗 Linked issue

Resolves #6325

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The InputTags theme was missing the fieldGroupVariant spread in its variants definition. This caused the component to not properly adjust its border radius when used inside a FieldGroup.

This PR imports fieldGroupVariant from ./field-group and spreads it into the variants object in src/theme/input-tags.ts, aligning InputTags with other form components like Input, InputNumber, Select and SelectMenu.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions Bot added the v4 #4488 label Apr 9, 2026
@mateusznarowski mateusznarowski force-pushed the fix/input-tags-field-group-variant branch from 7da6f8e to d60dd53 Compare April 9, 2026 10:15
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ab4b9890-76b7-4ef3-ad87-4b040f2a2702

📥 Commits

Reviewing files that changed from the base of the PR and between ae693d0 and d60dd53.

📒 Files selected for processing (1)
  • src/theme/input-tags.ts

📝 Walkthrough

Walkthrough

The src/theme/input-tags.ts file has been updated to import fieldGroupVariant and merge it into the component's variants configuration via object spread syntax. This adds field group variant support to InputTags, matching the pattern already implemented in other form components like Input, InputNumber, Select, and SelectMenu. The existing size and variant definitions are preserved alongside the newly merged variants.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding the missing fieldGroupVariant to InputTags component theme.
Description check ✅ Passed The description is well-related to the changeset, explaining the bug, its impact, and the solution with context about similar components.
Linked Issues check ✅ Passed The PR successfully addresses issue #6325 by importing fieldGroupVariant and spreading it into InputTags variants, matching the requirement for consistent field group behavior.
Out of Scope Changes check ✅ Passed All changes are directly related to resolving issue #6325; only the necessary import and variant spread were added with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 9, 2026

npm i https://pkg.pr.new/@nuxt/ui@6326

commit: d60dd53

Copy link
Copy Markdown
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😊

@benjamincanac benjamincanac merged commit aae5378 into nuxt:v4 Apr 9, 2026
30 of 31 checks passed
@mateusznarowski mateusznarowski deleted the fix/input-tags-field-group-variant branch April 9, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InputTags missing field group variant

2 participants