Skip to content

fix(PricingTable): handle RTL mode#6382

Merged
benjamincanac merged 1 commit intonuxt:v4from
malik-jouda:v4_msh6
Apr 21, 2026
Merged

fix(PricingTable): handle RTL mode#6382
benjamincanac merged 1 commit intonuxt:v4from
malik-jouda:v4_msh6

Conversation

@malik-jouda
Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Before

Screenshot 2026-04-21 at 8 08 38 PM

After

Screenshot 2026-04-21 at 8 11 00 PM

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions Bot added the v4 #4488 label Apr 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

📝 Walkthrough

Walkthrough

The src/theme/pricing-table.ts file was updated to support right-to-left (RTL) layouts. Tailwind class strings for the th header slot and the tier slot were modified to include rtl:text-right alongside existing left-aligned styling. This change ensures the pricing table component adapts correctly to RTL text directions. No logic modifications or exported entity declarations were altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding RTL (right-to-left) layout support to the PricingTable component.
Description check ✅ Passed The description relates to the changeset by including before/after screenshots showing the PricingTable component's visual changes, and indicates this is a bug fix for RTL mode handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/theme/pricing-table.ts (1)

28-28: ⚠️ Potential issue | 🟡 Minor

Add text alignment to title slots for complete RTL support.

The sectionTitle (line 28), featureTitle (line 30), and tierTitle (line 16) slots contain text but have no explicit text alignment. While container slots like th and tier include text-left rtl:text-right, these title slots rely on default alignment, which won't adapt in RTL layouts. Add consistent text alignment to all three: text-left rtl:text-right.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/theme/pricing-table.ts` at line 28, The title slot class definitions
(sectionTitle, featureTitle, and tierTitle) lack explicit alignment, so they
won't flip in RTL; update the values for sectionTitle, featureTitle, and
tierTitle to include "text-left rtl:text-right" alongside their existing classes
so titles follow the container RTL behavior (e.g., append or insert text-left
rtl:text-right into the class strings for sectionTitle, featureTitle, and
tierTitle).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@src/theme/pricing-table.ts`:
- Line 28: The title slot class definitions (sectionTitle, featureTitle, and
tierTitle) lack explicit alignment, so they won't flip in RTL; update the values
for sectionTitle, featureTitle, and tierTitle to include "text-left
rtl:text-right" alongside their existing classes so titles follow the container
RTL behavior (e.g., append or insert text-left rtl:text-right into the class
strings for sectionTitle, featureTitle, and tierTitle).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ed9f223a-78e5-487b-8620-699d2631658e

📥 Commits

Reviewing files that changed from the base of the PR and between 0daacb0 and 04be476.

⛔ Files ignored due to path filters (2)
  • test/components/__snapshots__/PricingTable-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/PricingTable.spec.ts.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • src/theme/pricing-table.ts

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 21, 2026

npm i https://pkg.pr.new/@nuxt/ui@6382

commit: 04be476

Copy link
Copy Markdown
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @malik-jouda! 😊

@benjamincanac benjamincanac merged commit ab203db into nuxt:v4 Apr 21, 2026
18 checks passed
@malik-jouda malik-jouda deleted the v4_msh6 branch April 21, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants