fix(PricingTable): handle RTL mode#6382
Conversation
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/theme/pricing-table.ts (1)
28-28:⚠️ Potential issue | 🟡 MinorAdd text alignment to title slots for complete RTL support.
The
sectionTitle(line 28),featureTitle(line 30), andtierTitle(line 16) slots contain text but have no explicit text alignment. While container slots likethandtierincludetext-left rtl:text-right, these title slots rely on default alignment, which won't adapt in RTL layouts. Add consistent text alignment to all three:text-left rtl:text-right.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/theme/pricing-table.ts` at line 28, The title slot class definitions (sectionTitle, featureTitle, and tierTitle) lack explicit alignment, so they won't flip in RTL; update the values for sectionTitle, featureTitle, and tierTitle to include "text-left rtl:text-right" alongside their existing classes so titles follow the container RTL behavior (e.g., append or insert text-left rtl:text-right into the class strings for sectionTitle, featureTitle, and tierTitle).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/theme/pricing-table.ts`:
- Line 28: The title slot class definitions (sectionTitle, featureTitle, and
tierTitle) lack explicit alignment, so they won't flip in RTL; update the values
for sectionTitle, featureTitle, and tierTitle to include "text-left
rtl:text-right" alongside their existing classes so titles follow the container
RTL behavior (e.g., append or insert text-left rtl:text-right into the class
strings for sectionTitle, featureTitle, and tierTitle).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ed9f223a-78e5-487b-8620-699d2631658e
⛔ Files ignored due to path filters (2)
test/components/__snapshots__/PricingTable-vue.spec.ts.snapis excluded by!**/*.snaptest/components/__snapshots__/PricingTable.spec.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (1)
src/theme/pricing-table.ts
commit: |
🔗 Linked issue
❓ Type of change
📚 Description
Before
After
📝 Checklist