Skip to content

fix(Avatar): remove leading-none from fallback#6383

Merged
benjamincanac merged 2 commits intonuxt:v4from
malik-jouda:v4_msh7
Apr 22, 2026
Merged

fix(Avatar): remove leading-none from fallback#6383
benjamincanac merged 2 commits intonuxt:v4from
malik-jouda:v4_msh7

Conversation

@malik-jouda
Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions Bot added the v4 #4488 label Apr 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: db8dfcf0-257d-47f3-bb1a-0c7706f7f246

📥 Commits

Reviewing files that changed from the base of the PR and between ab203db and b558133.

⛔ Files ignored due to path filters (4)
  • test/components/__snapshots__/Avatar-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/Avatar.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/AvatarGroup-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/AvatarGroup.spec.ts.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • src/theme/avatar.ts

📝 Walkthrough

Walkthrough

A single CSS utility class (leading-none) was removed from the fallback slot styling in the avatar theme configuration. The fallback slot class string was updated from font-medium leading-none text-muted truncate to font-medium text-muted truncate, which alters the line-height behavior for fallback content display.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal but related to the changeset, as it marks the PR as a bug fix without detailing specifics; however, it does not articulate what problem the change solves. Consider adding a brief explanation of why removing leading-none fixes the issue, such as the visual or layout problem it resolves.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing leading-none from the Avatar fallback slot, which directly matches the code modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 21, 2026

npm i https://pkg.pr.new/@nuxt/ui@6383

commit: b558133

@benjamincanac benjamincanac merged commit 77ce09a into nuxt:v4 Apr 22, 2026
18 checks passed
@malik-jouda malik-jouda deleted the v4_msh7 branch April 23, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants