Add Cmake flag to ensure we're propagating thread_count#1102
Add Cmake flag to ensure we're propagating thread_count#1102reazulhoque merged 1 commit intobranch-24.01from
Conversation
|
@reazulhoque please add the sign key to your GitHub account. the policy is that we don't accept PRs with unverified or unsigned commits. |
|
also I don't recall we had any issue with the parallel build... can you describe what you're trying to fix with this PR? |
|
@magnatelee We are propagating to cmake what users have provided with Without this fix user provided option will not be respected by cmake. |
5e800f0 to
a6fedd6
Compare
|
To be clear, install.py does pass -j directly to ninja/make, which is the last stage of the build, and covers all C++ compilation. We would have to pass this to cmake if we were using cmake --build rather than ninja/make directly. The problem is that compilation of the rust profiler expects to read -j from cmake. |
manopapad
left a comment
There was a problem hiding this comment.
If you can, please also open a corresponding PR on https://github.com/nv-legate/legate.core.
Thread count is not being propagated to Cmake. This fixes that.