Implementation of atleast_{1,2,3}d
#404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
reviewed
Jun 22, 2022
the final shapes of arrays
magnatelee
reviewed
Jun 25, 2022
magnatelee
reviewed
Jun 25, 2022
Contributor
and modified 'test_atleast_nd.py' to use LEGATE_MAX_DIM
Contributor
|
@magnatelee FYI I was just about to ask if these might be able to be added soon -- some test improvements I would like to consider making relies on |
manopapad
reviewed
Jul 19, 2022
Contributor
|
Please add the new functions under |
manopapad
reviewed
Jul 19, 2022
manopapad
reviewed
Jul 19, 2022
manopapad
reviewed
Jul 20, 2022
manopapad
reviewed
Jul 20, 2022
manopapad
reviewed
Jul 20, 2022
…tleast_nd` is applied Added a test case for singleton arrays in `test_concatenate_stack`
manopapad
approved these changes
Jul 22, 2022
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Jul 29, 2022
* Atleast_{1,2,3}d the first implementation
* Added a test for atleast_nd routines
* Applied atleast_nd routines to `vstack` and `hstack`
* Added description of atleast_nd routines
* Modified to do 'reshape' only once for each arr after collecting
the final shapes of arrays
* Changed the 'atleast_nd' routines to use type annotations
and modified 'test_atleast_nd.py' to use LEGATE_MAX_DIM
* Made a change with reference to comments on PR regarding description of functions
* Made the `view` arugment in `_atleast_nd` not to use `Optional`
* Fixed the bug w/ singleton arrays for `vstack` and `dstack` after `_atleast_nd` is applied
Added a test case for singleton arrays in `test_concatenate_stack`
* Minor change for the output format in `tests/integration/test_atleast_nd.py`
* Delete unnecessary codes regarding `view`
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Jul 29, 2022
* Atleast_{1,2,3}d the first implementation
* Added a test for atleast_nd routines
* Applied atleast_nd routines to `vstack` and `hstack`
* Added description of atleast_nd routines
* Modified to do 'reshape' only once for each arr after collecting
the final shapes of arrays
* Changed the 'atleast_nd' routines to use type annotations
and modified 'test_atleast_nd.py' to use LEGATE_MAX_DIM
* Made a change with reference to comments on PR regarding description of functions
* Made the `view` arugment in `_atleast_nd` not to use `Optional`
* Fixed the bug w/ singleton arrays for `vstack` and `dstack` after `_atleast_nd` is applied
Added a test case for singleton arrays in `test_concatenate_stack`
* Minor change for the output format in `tests/integration/test_atleast_nd.py`
* Delete unnecessary codes regarding `view`
manopapad
pushed a commit
that referenced
this pull request
Nov 17, 2024
* Fix install.py for legate src-layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
np.atleast{1,2,3}dw/ a test.Changed
vstackanddstackto use the newly added routine,_atleast_nd