Skip to content

Conversation

@marcinz
Copy link
Collaborator

@marcinz marcinz commented Aug 5, 2022

Curand is provided as a separate package in the Nvidia conda packaging system. The Nvidia channel cudart-dev package relies on some include files from cuda-nvcc. This is probably a bug (reported), but for now we need cuda-nvcc for the files that are included from curand and then from cudart.

@marcinz
Copy link
Collaborator Author

marcinz commented Aug 5, 2022

This will be backported to branch-22.07 when successfully merged.

@marcinz marcinz requested a review from m3vaz August 5, 2022 05:56
@marcinz
Copy link
Collaborator Author

marcinz commented Aug 5, 2022

@fduguet-nv I am assuming that for GPU we need the curand .so files? For CPU, we are assuming that the library is include-only.

@m3vaz
Copy link
Contributor

m3vaz commented Aug 5, 2022

Other than the trailing P, LGTM.

@manopapad
Copy link
Contributor

Is cuRAND included at all on a CPU-only build?

@marcinz
Copy link
Collaborator Author

marcinz commented Aug 5, 2022

Hmm, I think you're right @manopapad. I assumed that curand was activated automatically, soI thought it was getting built, but I think I need to activate it explicitly. I did not notice I put it only in the GPU section. Let me fix that.

@marcinz marcinz requested a review from manopapad August 5, 2022 17:53
@marcinz marcinz requested a review from m3vaz August 5, 2022 18:12
@marcinz
Copy link
Collaborator Author

marcinz commented Aug 5, 2022

OK, I think it should be better now. I added flags to actually build with curand on CPU.

Copy link
Contributor

@manopapad manopapad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the abstract, but we'll know for sure when we try to build :-D

@marcinz
Copy link
Collaborator Author

marcinz commented Aug 5, 2022

I built all the variants locally, and it worked. I will commit, and back port. After I do that, @m3vaz could you try it too?

@marcinz marcinz merged commit ab5d0d2 into nv-legate:branch-22.10 Aug 5, 2022
marcinz added a commit to marcinz/cunumeric that referenced this pull request Aug 5, 2022
Conda packages now build with support for curand both in the CPU and the GPU builds.

Co-authored-by: Marcin Zalewski <mzalewski@nvidia.com>
marcinz added a commit that referenced this pull request Aug 5, 2022
Conda packages now build with support for curand both in the CPU and the GPU builds.

Co-authored-by: Marcin Zalewski <mzalewski@nvidia.com>
sbak5 pushed a commit to sbak5/cunumeric that referenced this pull request Aug 17, 2022
Conda packages now build with support for curand both in the CPU and the GPU builds.

Co-authored-by: Marcin Zalewski <mzalewski@nvidia.com>
manopapad pushed a commit that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants