-
Notifications
You must be signed in to change notification settings - Fork 88
Add support for curand conda package build #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This will be backported to |
|
@fduguet-nv I am assuming that for GPU we need the curand |
|
Other than the trailing P, LGTM. |
|
Is cuRAND included at all on a CPU-only build? |
|
Hmm, I think you're right @manopapad. I assumed that curand was activated automatically, soI thought it was getting built, but I think I need to activate it explicitly. I did not notice I put it only in the GPU section. Let me fix that. |
|
OK, I think it should be better now. I added flags to actually build with curand on CPU. |
manopapad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in the abstract, but we'll know for sure when we try to build :-D
|
I built all the variants locally, and it worked. I will commit, and back port. After I do that, @m3vaz could you try it too? |
Conda packages now build with support for curand both in the CPU and the GPU builds. Co-authored-by: Marcin Zalewski <mzalewski@nvidia.com>
Conda packages now build with support for curand both in the CPU and the GPU builds. Co-authored-by: Marcin Zalewski <mzalewski@nvidia.com>
Curand is provided as a separate package in the Nvidia conda packaging system. The Nvidia channel
cudart-devpackage relies on some include files fromcuda-nvcc. This is probably a bug (reported), but for now we needcuda-nvccfor the files that are included from curand and then from cudart.