Fixing logic for slicing #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipdemes
added
the
category:bug-fix
manopapad
reviewed
Sep 6, 2022
manopapad
reviewed
Sep 6, 2022
cunumeric/deferred.py
Outdated
| store_copy.copy(store_to_copy, deep=True) | ||
| return cast(DeferredArray, store_copy) | ||
|
|
||
| def _slice_store( |
Contributor
There was a problem hiding this comment.
Can you make this into a @staticmethod, since it doesn't really use the self argument?
manopapad
reviewed
Sep 6, 2022
manopapad
reviewed
Sep 8, 2022
cunumeric/deferred.py
Outdated
| end = 0 | ||
| step = 1 | ||
| k = slice(start, end, step) | ||
| # if ( |
Contributor
There was a problem hiding this comment.
Remove this commented-out code
manopapad
approved these changes
Sep 8, 2022
Contributor
manopapad
left a comment
manopapad
left a comment
There was a problem hiding this comment.
Two remaining minor items, otherwise looks good
Contributor
Author
|
@manopapad : sorry I missed your comment about the static method. I have fixed everything and planning to merge after CI passes |
This was referenced Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes nv-legate/legate#329 and #515