Do reductions properly in tensor contraction tasks #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
added
the
category:bug-fix
manopapad
approved these changes
Feb 17, 2023
Contributor
|
Do you maybe want to call it |
Contributor
Author
I'll actually rename it to |
Contributor
Author
|
Merging this PR without making it go through the CI, as it's broken more than a week now... |
shixun404
pushed a commit
to shixun404/cupynumeric
that referenced
this pull request
Sep 18, 2025
* Update array_dimension.py * Update test_squeeze.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tensor contraction tasks (matmul, matvecmul, and contract) were overwriting the LHS even though the LHS was passed as a reduction store. This was causing nondeterministic correctness issues. This PR fixes that issue.