Using the new core type system#903
Merged
magnatelee merged 13 commits intonv-legate:branch-23.05from May 4, 2023
Merged
Conversation
magnatelee
added
the
category:task
jjwilke
approved these changes
Apr 25, 2023
Contributor
jjwilke
left a comment
jjwilke
left a comment
There was a problem hiding this comment.
LGTM. A few minor nits, but no blockers.
manopapad
reviewed
May 4, 2023
| p_samples, | ||
| num_samples_l * sizeof(SegmentSample<VAL>), | ||
| comm::coll::CollDataType::CollUint8, | ||
| comm::coll::CollDataType::Code::CollUint8, |
Contributor
There was a problem hiding this comment.
Overeager search/replace
shixun404
pushed a commit
to shixun404/cupynumeric
that referenced
this pull request
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the cuNumeric code to use the new core type system in nv-legate/legate#697. Though this PR updates almost every C++ file in the repository, the majority of changes is just to catch up the changes in type codes (
legate::LegateTypeCode=>legate::Type::Code).