bug fix in install.py #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@sunwayihep Thanks for this PR and sorry for the late response. The team is currently setting up contribution guidelines. Once we have them settled, we will merge this PR. |
Contributor
|
@sunwayihep Sorry for the late response. We're ready to merge this PR, but before doing so, we'd like you to sign off your commit: https://github.com/nv-legate/legate.core/blob/branch-22.01/CONTRIBUTING.md#how-do-i-sign-the-dco. Note that you should amend the commit, instead of reverting and recommitting it, otherwise the change without a sign-off still appears in the history. Again, thank you for your contribution! |
Signed-off-by: Wei Sun <swaysty@gmail.com>
Contributor
Author
|
@magnatelee Thanks for the notification, the sign-off was added to the commit. |
elliottslaughter
pushed a commit
to elliottslaughter/legate
that referenced
this pull request
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
find_active_python_version_and_pathfunction, thep.replace(".a", ".dylib" if os_name == "Darwin" else ".so")will lead to the bug if the directory path including the.asubstring, e.g./home/software.ihep.ac.cn/python/libxxx.awill be replaced with/home/software.ihep.soc.cn/python/libxxx.so, therefore a simple fix for this bug.