Skip to content

Don't apply python installation fix under setuptools<60 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manopapad merged 1 commit into from
Jan 27, 2022
Merged

Don't apply python installation fix under setuptools<60 #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,18 @@
import tempfile
from distutils import sysconfig

import setuptools

# Flush output on newlines
sys.stdout.reconfigure(line_buffering=True)

os_name = platform.system()

# Work around breaking change in setuptools 60
setup_py_flags = []
if int(setuptools.__version__.split(".")[0]) >= 60:
setup_py_flags = ["--single-version-externally-managed", "--root=/"]


class BooleanFlag(argparse.Action):
def __init__(
Expand Down Expand Up @@ -387,11 +394,10 @@ def build_legion(
sys.executable,
"setup.py",
"install",
"--single-version-externally-managed",
"--root=/",
"--prefix",
str(os.path.realpath(install_dir)),
],
]
+ setup_py_flags,
cwd=legion_python_dir,
)
verbose_check_call(
Expand Down Expand Up @@ -505,9 +511,7 @@ def build_legate_core(
"setup.py",
"install",
"--recurse",
"--single-version-externally-managed",
"--root=/",
]
] + setup_py_flags
if unknown is not None:
try:
prefix_loc = unknown.index("--prefix")
Expand Down