Skip to content

Be a little more lenient in fake-dims check #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manopapad merged 1 commit into from
Feb 26, 2022
Merged

Be a little more lenient in fake-dims check #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion legate/core/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,7 @@ def attach_external_allocation(self, context, alloc, share):
self._storage.attach_external_allocation(context, alloc, share)

def has_fake_dims(self):
return self._transform.add_fake_dims()
return self._transform.adds_fake_dims()

def comm_volume(self):
return self._storage.volume()
Expand Down
10 changes: 6 additions & 4 deletions legate/core/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def __hash__(self):
return hash((type(self), self._extra_dim, self._dim_size))

def adds_fake_dims(self):
return True
return self._dim_size > 1

@property
def convertible(self):
Expand Down Expand Up @@ -533,8 +533,10 @@ def __str__(self):
def __repr__(self):
return str(self)

def add_fake_dims(self):
return self._transform.adds_fake_dims() or self._parent.add_fake_dims()
def adds_fake_dims(self):
return (
self._transform.adds_fake_dims() or self._parent.adds_fake_dims()
)

@property
def convertible(self):
Expand Down Expand Up @@ -610,7 +612,7 @@ def __str__(self):
def __repr__(self):
return str(self)

def add_fake_dims(self):
def adds_fake_dims(self):
return False

@property
Expand Down