Skip to content

Conversation

@bryevdv
Copy link
Contributor

@bryevdv bryevdv commented Apr 7, 2022

This PR adds type annotations to the following modules

  • launcher
  • context
  • legate
  • operation
  • timing.*

and enables strict checking of all modules by default (explicit blocklist for remaining modules)

There are a few awkward types / aliases as well as instances of Any that were left in for now. These will be better to handle separately in later PRs

@bryevdv bryevdv requested a review from magnatelee April 7, 2022 22:48
@bryevdv
Copy link
Contributor Author

bryevdv commented Apr 11, 2022

@magnatelee
Copy link
Contributor

@bryevdv looks good to me. feel free to merge this once you confirm that all cuNumeric tests pass with this. (we really should automate that process.)

@bryevdv
Copy link
Contributor Author

bryevdv commented Apr 11, 2022

./test.py --use=cuda passes locally fo:

                     GPU: Passed   91 of   91 tests (100.0%)

############################################################
### Exiting Stage: GPU tests
###   * Exception Type: None
###   * Elapsed Time: 0:03:45.003129
############################################################

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   total: Passed   91 of   91 tests (100.0%)

@bryevdv bryevdv merged commit 7146131 into nv-legate:branch-22.05 Apr 11, 2022
@bryevdv bryevdv deleted the bryanv/mypy3 branch April 11, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants