-
Notifications
You must be signed in to change notification settings - Fork 63
More type annotations #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
reviewed
Apr 9, 2022
This was referenced Apr 11, 2022
Closed
Contributor
Author
|
FYI @magnatelee follow-on issues from this PR: |
Contributor
|
@bryevdv looks good to me. feel free to merge this once you confirm that all cuNumeric tests pass with this. (we really should automate that process.) |
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type annotations to the following modules
launchercontextlegateoperationtiming.*and enables strict checking of all modules by default (explicit blocklist for remaining modules)
There are a few awkward types / aliases as well as instances of Any that were left in for now. These will be better to handle separately in later PRs