Skip to content

Conversation

@bryevdv
Copy link
Contributor

@bryevdv bryevdv commented May 6, 2022

No description provided.

@manopapad
Copy link
Contributor

manopapad commented May 6, 2022

I also updated some python references in the README

Nevermind, I just saw the comment that Wonchan wants to update the README.

This reverts commit 5df94c2.
@m3vaz m3vaz self-requested a review May 6, 2022 22:09
Copy link
Contributor

@m3vaz m3vaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The falsey value is required to trigger the cpu only spec. Please do not remove it from the recipe.

@bryevdv
Copy link
Contributor Author

bryevdv commented May 6, 2022

@m3vaz 8fa0b0a

Hopefully someday conda-build can offer a better approach. My editor is set to trim trailing whitespace automatically, and I expect that is fairly common.

@m3vaz
Copy link
Contributor

m3vaz commented May 7, 2022

LGTM, Please tag me when you have the cunumeric PR ready as well

@bryevdv bryevdv merged commit a5e04c2 into nv-legate:branch-22.05 May 8, 2022
@bryevdv bryevdv deleted the minpy_38 branch May 8, 2022 19:44
manopapad pushed a commit that referenced this pull request Mar 5, 2025
* Add unit tests for Array.

* 1. fix test failures.
2. fix build failures duo to the rename.

* another fix to test failure.

* Address review comments.

* Fix build failures with -Werror=shadow.

* Address comments.

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants