Fixes for building with setup.py outside conda, primarily Mac (#260) #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjwilke
commented
Jun 8, 2022
jjwilke
commented
- Updates shebangs to use python3 since python still defaults to python2 instances on many platforms
- Validates -march with compiler before adding to flags
jjwilke
force-pushed
the
mac-build-fixes-260
branch
from
dbc1258 to
6b49dc4
Compare
manopapad
reviewed
Jun 8, 2022
jjwilke
force-pushed
the
mac-build-fixes-260
branch
from
353603b to
4341fd7
Compare
manopapad
approved these changes
Jun 14, 2022
Contributor
|
@jjwilke feel free to merge this PR |
jjwilke
force-pushed
the
mac-build-fixes-260
branch
from
894ae4e to
365e1b8
Compare
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
* Properly PIMPL-ize DimOrdering for smart pointers * Disable the is_pure_move_XXX sfinae tests for NVCC, for which they don't appear to work? * Use legate::SharedPtr and legate::InternalSharedPtr in the repo * InternalWeakPtr and shared ptr reorganization and add EnableSharedFromThis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.