use mpicc to compile the code when gasnet is enabled #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
reviewed
Jun 15, 2022
src/legate.mk
Outdated
|
|
||
| RM := rm | ||
|
|
||
| # use mpi{cc,cxx,f90} compiler wrappers if USE_MPI=1 and we're not on a Cray system |
Contributor
There was a problem hiding this comment.
USE_MPI should be USE_GASNET
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed now.
magnatelee
approved these changes
Jun 15, 2022
manopapad
reviewed
Jun 15, 2022
src/legate.mk
Outdated
| ifneq ($(strip $(shell __INTEL_POST_CFLAGS+=' -we10006' $(CC) -show 2>&1 > /dev/null; echo $$?)),0) | ||
| export OMPI_CC := $(CC) | ||
| export MPICH_CC := $(CC) | ||
| CC := mpicc |
Contributor
There was a problem hiding this comment.
Can you fix the alignment here?
Contributor
Author
There was a problem hiding this comment.
good catch, somehow the alignment is OK in my vscode. Is there a way to let pre-commit catch the format issue of makefile?
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.