let gasnet to handle mpi init and finalize #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
reviewed
Jun 15, 2022
src/core/comm/coll.cc
Outdated
| CHECK_MPI(MPI_Finalized(&fina_flag)); | ||
| if (fina_flag == 0) { CHECK_MPI(MPI_Finalize()); } | ||
| if (fina_flag == 1) { | ||
| log_coll.fatal("MPI should not been finalized"); |
Contributor
There was a problem hiding this comment.
Typo: "MPI should not have been finalized"
Contributor
Author
There was a problem hiding this comment.
Thanks, it should have been fixed now.
magnatelee
approved these changes
Jun 15, 2022
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
* Permission checks for all code paths creating accessors * Update the default for tester * Fix the test to make it pass on multiple CPUs and some modernization changes * Add multi-CPU testing to CI * Update tests/cpp/unit/physical_store.cc Co-authored-by: Jacob Faibussowitsch <jacob.fai@gmail.com> --------- Co-authored-by: Jacob Faibussowitsch <jacob.fai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a case that GASNet will crash if I finalize the MPI in the
collFinalizefunction, so we will just let GASNet to handle the initialization and finalization of MPI.