Pass CMAKE_GENERATOR to scikit-build
#529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerator detection
…fix/install-py-cmake-generator
for more information, see https://pre-commit.ci
…fix/install-py-cmake-generator
…legate.core into fix/install-py-cmake-generator
trxcllnt
added
the
category:improvement
jjwilke
requested changes
Jan 12, 2023
Contributor
jjwilke
left a comment
jjwilke
left a comment
There was a problem hiding this comment.
LGTM, pending the variable name
jjwilke
approved these changes
Jan 12, 2023
…fix/install-py-cmake-generator
…fix/install-py-cmake-generator
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
Ignoring (known) "Build and test (linux, cpu, debug-sanitizer-gcc, false)" failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures scikit-build uses the desired generator for all CMake invocations. This short-circuits scikit-build's internal generator "detection" logic, which caused failures if they detected a different generator than the one we were specifying.