Change the default CPU architecture to haswell. #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This should be the default only when building on an x86 machine. Please add a comment for why we're doing this in the script itself. This should also be changed on the cunumeric side. |
Collaborator
Author
|
@manopapad Do we have a check whether we are building on an x86 machine? If we do not, maybe this is not a good idea. |
Contributor
Contributor
|
Seems reasonable to me |
trxcllnt
added
the
category:improvement
trxcllnt
reviewed
Jan 20, 2023
install.py
Outdated
| dest="march", | ||
| required=False, | ||
| default="native", | ||
| default="haswell", |
Contributor
There was a problem hiding this comment.
Suggested change
| default="haswell", | |
| default=("haswell" if platform.machine() == "x86_64" else "native"), |
manopapad
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default architecture to haswell. Currently, we build our conda packages with haswell to avoid compatibility issues. Changing the default architecture to haswell will make default builds comparable to the conda packages and it will allow developers to share sccache with CI builds.