Use data structures with deterministic iteration order in the solver #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With non-deterministic iteration orders we may end up emitting runtime calls in a different order on different shards, thus causing control replication violations.
jjwilke
pushed a commit
to jjwilke/legate.core
that referenced
this pull request
Sep 29, 2023
…v-legate#58) * Make sure we don't configure nonexistent modules * Use Legate flags in test scripts * Make scales template arguments * Minor tweak to the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With non-deterministic iteration orders we may end up emitting
runtime calls in a different order on different shards, thus
causing control replication violations.