Mapper refactoring #676
Merged
Mapper refactoring #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
added
the
category:improvement
This was referenced Apr 11, 2023
* Libraries can now have only one mapper that should be provided at the registration time * If no mapper is given, the default mapper will be used for the library * All mapper id parameters are removed from the APIs
jjwilke
approved these changes
Apr 14, 2023
Contributor
jjwilke
left a comment
jjwilke
left a comment
There was a problem hiding this comment.
LGTM. A couple minor nits.
src/core/mapping/default_mapper.h
Outdated
| TaskTarget task_target(const Task& task, const std::vector<TaskTarget>& options); | ||
| std::vector<StoreMapping> store_mappings(const Task& task, | ||
| const std::vector<StoreTarget>& options); | ||
| virtual Scalar tunable_value(TunableID tunable_id); |
Contributor
There was a problem hiding this comment.
Does this need to be marked virtual?
Contributor
Author
There was a problem hiding this comment.
my initial thought is that there could be some mappers that would only have custom tunables (though that'd need the machine query interface to be protected), but now I think that'd rather need a custom mapper. let me remove that.
src/core/mapping/default_mapper.h
Outdated
|
|
||
| public: | ||
| void set_machine(const MachineQueryInterface* machine); | ||
| TaskTarget task_target(const Task& task, const std::vector<TaskTarget>& options); |
Contributor
There was a problem hiding this comment.
Should these be marked override?
Contributor
Author
There was a problem hiding this comment.
yup, I forgot to put those. Will add them.
manopapad
approved these changes
Apr 14, 2023
rapids-bot bot
pushed a commit
to rapidsai/kvikio
that referenced
this pull request
May 11, 2023
See nv-legate/legate#675 and nv-legate/legate#676 Authors: - Mads R. B. Kristensen (https://github.com/madsbk) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the internal discussion, this PR implements the following changes to the Legate mapper:
This PR builds on #675 and so it currently inherits all of the changes. I will rebase this PR once #675 is merged.