Add --ranks-per-node option to tester #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
added
the
category:improvement
manopapad
changed the title
manopapad
requested changes
Jun 5, 2023
Contributor
manopapad
left a comment
manopapad
left a comment
There was a problem hiding this comment.
Mostly nits, and what looks like one double-counting of config.ranks in GPU phase compute_spec.
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
Contributor
Author
|
@manopapad I pushed changes for OMP let me know if this matches intent |
manopapad
requested changes
Jun 7, 2023
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
manopapad
approved these changes
Jun 7, 2023
Contributor
manopapad
left a comment
manopapad
left a comment
There was a problem hiding this comment.
LGTM. The CI failures are unrelated, and can be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
--node-per-ranktolegate.tester