Skip to content

Patch matx so that it doesn't fail when LIBCUDACXX_VERSION is empty#44

Merged
rapids-bot[bot] merged 2 commits intonv-morpheus:branch-23.07from
drobison00:devin_matx_libcudacxx_version_fix
Jun 13, 2023
Merged

Patch matx so that it doesn't fail when LIBCUDACXX_VERSION is empty#44
rapids-bot[bot] merged 2 commits intonv-morpheus:branch-23.07from
drobison00:devin_matx_libcudacxx_version_fix

Conversation

@drobison00
Copy link
Contributor

Sometimes Matx ends up configuring LIBCUDACXX_VERSION as an empty string, which causes it to fail. This patch checks for that condition and ensures that libcudacxx is set to something.

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@drobison00 drobison00 requested a review from a team as a code owner June 13, 2023 17:28
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drobison00 drobison00 added enhancement Additional functionality added to an existing feature non-breaking Non-breaking change 5 - Ready to Merge PR is complete and has been reviewed; ready to merge improvement Improvement to existing functionality labels Jun 13, 2023
@drobison00
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ad81faa into nv-morpheus:branch-23.07 Jun 13, 2023
@drobison00 drobison00 deleted the devin_matx_libcudacxx_version_fix branch June 13, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge PR is complete and has been reviewed; ready to merge enhancement Additional functionality added to an existing feature improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants