Do not restrict workflow triggers to addon path#22
Merged
seanbudd merged 1 commit intonvaccess:masterfrom Mar 4, 2026
Merged
Conversation
Member
|
Happy to merge this, I think it would be nice to have a solution that avoids checks failing on PRs like this though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In #21, a restriction has been added to workflow triggers so that the workflow runs only if files in the addon subfolder are modified.
Though as discussed in #21 (comment), modifying files outside the
addonfolder may have an impact on the generated.addonfile:readme.md,style.css)buildVars.pycontrols the bundled manifest file,sconstructmodification can have any effect, including on what is in the bundle, etc.Solution
Removed the path restriction.
Note
Alternative solution was discussed, e.g. exclude some folders from the trigger rather than including only the "addon" folder. Though, it seems to me that making any hypothesis on which file / folder impacts the add-on bundle's content is quite fragile.