build problems

[mdlawler]

I get the following build problem:
scons: Building targets ...
cl /Fobuild\arm64\cppjieba\cppjieba.obj /c build\arm64\cppjieba\cppjieba.cpp /TP /EHsc /wd4819 /nologo /Od /std:c++20 /permissive- /MT /wd4819 /DUNICODE /D_CRT_SECURE_NO_DEPRECATE /DLOGLEVEL=15 /D_WIN32_WINNT=_WIN32_WINNT_WIN10 /DNOMINMAX /DNDEBUG /Iinclude\cppjieba\include\cppjieba /Iinclude\cppjieba\deps\limonp\include /Iinclude /Iinclude\wil\include /Imiscdeps\include /Ibuild\arm64 /Z7
cppjieba.cpp
C:\nvda\nvda\include\cppjieba\include\cppjieba\QuerySegment.hpp(7): fatal error C1083: Cannot open include file: 'limonp/Logging.hpp': No such file or directory
scons: *** [build\arm64\cppjieba\cppjieba.obj] Error 2
scons: building terminated because of errors.
This folder is empty
C:\nvda\nvda\include\cppjieba\deps\limonp
Is anyone else seeing this?
git submodule update
doesn't do anything.

[CyrilleB79]

Hi

I've had the same problem.
I think it's a submodule of the submodule. So:
git submodule update --recursive
And maybe before:
git submodule sync --recursive

[mdlawler]

I tried those and the directory is still empty. I removed the entire cppjieba folder and then used those commands and got the cppjieba files back, but the deps\limonp directory is still empty.

[mdlawler]

So that you don't break your system if you rename your include\cppjieba directory to include\cppjieba.bak and do the git commands do you get files in the include\cppjieba\deps\limonp directory?

[CyrilleB79]

Or maybe with the --init flag, i.e.:

git submodule sync --recursive
git submodule update --init --recursive

I know I've tried it but do not remember if which trial proved to be successful.

[ABuffEr]

git submodule sync --recursive
git submodule update --init --recursive

This worked, thanks!

[mdlawler]

Yes the above also worked for me thanks. I wonder if the docs for creating the dev environment need to be updated for this.

[CyrilleB79]

I have opened #20853 to update the documentation. Let me know if it seems OK to you. Thanks!

[mdlawler]

This looks good to me. To clarify I did pass --recursive when creating my original clone. I think the problem happens when a new submodule is added that also has submodules as I've not seen this problem before the cppjieba module was added with the limonp submodule. I don't know if clarifying this is important that these commands would be necessary in the case where a new submodule was added that also contained its own submodules like the cppjieba/limonp case did.

[CyrilleB79]

Yes, FWIK, cppjieba is the first submodule which has itself a submodule.

I have not detailed the difference between submodule and nested submodules to avoid complexifying the documentation; seemed to me that recommending git submodule --init --recursive was enough. Let's see NV Access feedback.