-
-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nvda does not automatically read messages received on skype for business #9295
Comments
@fernando-jose-silva is this issue also reproducible in NVDA 2019.1.1? |
yes, this is still a problem, tested on nvda 2019.1.1 and alpha 17077. |
I have just reproduced the issue here with NVDA 2020.4 and Skype for business 2016 (16.0.5095.1000). Technical detailsWhen a new message occurs in the conversation, the following error appears in the log and the message is not vocalized:
If I put the navigation object (and the focus) on the last message and open the log, I get the following dev info:
Looking at the comments in lync.py appModule that manages this application, it is clear that it was not expected that the object containing the message have a value set to None. |
…s of Skype for Business. (#12122) Fixes #9295 Summary of the issue: In Skype for Business (at least Office 2016, version 16.0.5095.1000), the incoming messages are not reported and an error occurs in the log instead. This error show that the message has a value set to None whereas the code expects a string in order to parse it. (cf. #9295 (comment) for more details) Description of how this pull request fixes the issue: If the message value is None, parse only the message name to split the content from author and timestamp parts. For this, we just look at ", , " separators. If the message is not None, use as previously the message name and the message value to split author, content and timestamp of the message.
Fix-up of #9295 . Summary of the issue: Some excessive errors were logged in the log while using Skype for Business. In #9295, an error is logged when the new chat message does not follow the person+content+timestamp message. The majority of message have such pattern but some information message don't, e.g.: message indicating the start or end of a call first message of the chat containing a warning about privacy Excessive error logging is misleading when making NVDA or add-on tests. Description of how this pull request fixes the issue: log.error replaced by log.debug since this codepath is expected. The log is still kept in case an unknown message pattern is found in another version of Skype or with another usage.
Steps to reproduce:
I'm sure I've seen this working for some time.
I have not used skype for business for a long time but in my current work I'm making use of it again, and when I received a message on skype for business, nvda did not automatically read the received message.
Open a conversation on skype for business type something and wait inside the conversation for your partner to respond.
Actual behavior:
The nvda is mute.
Expected behavior:
Nvda should automatically announce the response received.
System configuration
NVDA installed/portable/running from source:
install
NVDA version:
2018.4.1
Windows version:
10 17134.556
Name and version of other software in use when reproducing the issue:
office 16.0.4266.1001
Other information about your system:
Other questions
Does the issue still occur after restarting your PC?
yes
Have you tried any other versions of NVDA?
no
The text was updated successfully, but these errors were encountered: