-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference to visual studio code project repository #10064
Conversation
@bramd: could you also have a look? |
@LeonarddeR err... it looks like the submodule was not actually added? the only two files changed in this pr are readme.md and .gitignore. |
@michaelDCurran: I'm sorry, I noticed that the description of the pr referenced the old situation where we used a submodule. @feerrenrut pointed out that it might be better to use a system where one has to check out the repository manually. See nvaccess/vscode-nvda#1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LeonarddeR
Link to issue number:
Depends on nvaccess/vscode-nvda#1
Closes #9971
Summary of the issue:
Visual Studio Code is currently well known for its accessibility and ease of use. Especially since the NVDA repository has a linting configuration built in, using Visual Studio Code's linter support is pretty handy for non visually working programmers.
Description of how this pull request fixes the issue:
Added a reference in the readme to a preconfigured VSCode workspace. This has to be checked out in the main source directory of NVDA.
.gitignore
deals with this.Several settings a configured in this project, see also nvaccess/vscode-nvda#1:
The current NVDA build environment is set up in such a way that it doesn't require a virtual Python environment.
This VSCode project does not define the python interrpetter setting by default.
Testing performed:
Tested that tests run from VS Code and that extra include directories are recognized.
Known issues with pull request:
None
Change log entry: