Skip to content

chore: Add getFromStream to ViewModel#56

Merged
jeanplevesque merged 1 commit intomainfrom
dev/jpl/get-from-stream
Feb 18, 2025
Merged

chore: Add getFromStream to ViewModel#56
jeanplevesque merged 1 commit intomainfrom
dev/jpl/get-from-stream

Conversation

@jeanplevesque
Copy link
Copy Markdown
Member

@jeanplevesque jeanplevesque commented Feb 18, 2025

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

  • Add getFromStream to have ViewModel properties that automatically update based on Stream sources.

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and src/cli/CLI.md if you made changes to templating.
    • Update AzurePipelines.md and src/app/README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@jeanplevesque jeanplevesque force-pushed the dev/jpl/get-from-stream branch from fba7c41 to 5c5aaee Compare February 18, 2025 16:36
@jeanplevesque jeanplevesque changed the title chore: Add getFromStream to have ViewModel properties that automatica… chore: Add getFromStream to ViewModel Feb 18, 2025
@jeanplevesque jeanplevesque requested a review from a team February 18, 2025 16:37
@jeanplevesque jeanplevesque force-pushed the dev/jpl/get-from-stream branch from 5c5aaee to 8e7487a Compare February 18, 2025 16:44
@jeanplevesque jeanplevesque merged commit c2c92bc into main Feb 18, 2025
@jeanplevesque jeanplevesque deleted the dev/jpl/get-from-stream branch February 18, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants