chore: support request id#22
Merged
virajkarandikar merged 4 commits intonvidia-riva:mainfrom Aug 8, 2023
Merged
Conversation
Can be used to track the request info when we enable storing per request data.
Contributor
|
LGTM |
junkin
reviewed
Jul 25, 2023
Contributor
junkin
left a comment
junkin
left a comment
There was a problem hiding this comment.
Should this also take a request_id on request, and if that exists use that instead as a pass through?
Contributor
Author
Can do this |
junkin
reviewed
Aug 2, 2023
Contributor
junkin
left a comment
junkin
left a comment
There was a problem hiding this comment.
Would also want this reflected in the riva_nlp.proto
virajkarandikar
force-pushed
the
add_request_id
branch
3 times, most recently
from
dc1de80 to
da0d75b
Compare
virajkarandikar
force-pushed
the
add_request_id
branch
from
da0d75b to
1d33d7d
Compare
Contributor
Author
|
Using higher enum value for request_id to keep it consistent. |
virajkarandikar
changed the title
virajkarandikar
changed the title
virajkarandikar
force-pushed
the
add_request_id
branch
2 times, most recently
from
4523309 to
fbc6938
Compare
virajkarandikar
force-pushed
the
add_request_id
branch
from
fbc6938 to
aaaa890
Compare
junkin
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be used to track the request info when we enable storing per request data.