Add dnt support in s2s ( Proto changes)#38
Merged
rmittal-github merged 1 commit intonvidia-riva:release/2.17.0from Aug 28, 2024
Merged
Add dnt support in s2s ( Proto changes)#38rmittal-github merged 1 commit intonvidia-riva:release/2.17.0from
rmittal-github merged 1 commit intonvidia-riva:release/2.17.0from
Conversation
Contributor
|
@shiralal please rebase on top of |
shiralal
force-pushed
the
add-dnt-support-in-s2s
branch
from
2df3e2c to
20ce617
Compare
Contributor
Author
rebased on |
shiralal
force-pushed
the
add-dnt-support-in-s2s
branch
from
20ce617 to
0c25d46
Compare
rmittal-github
approved these changes
Aug 28, 2024
Contributor
rmittal-github
left a comment
rmittal-github
left a comment
There was a problem hiding this comment.
LGTM, will wait for CI to complete before merge
shiralal
force-pushed
the
add-dnt-support-in-s2s
branch
from
0c25d46 to
947848d
Compare
rmittal-github
added a commit
that referenced
this pull request
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added dnt_phrases parameter in translation_config.