This repository was archived by the owner on Oct 13, 2021. It is now read-only.
refactor: replace goto for Lua 5.1 compatibility#60
Merged
haorenW1025 merged 1 commit intonvim-lua:masterfrom May 11, 2020
Merged
refactor: replace goto for Lua 5.1 compatibility#60haorenW1025 merged 1 commit intonvim-lua:masterfrom
haorenW1025 merged 1 commit intonvim-lua:masterfrom
Conversation
Collaborator
|
Oh I didn't actually know that... I used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 I tried out this plugin with Neovim nightly via the unstable PPA on a clean install of Ubuntu 20.04, and I got the following error on when I run
lua require'completion'.on_attach():It turns out that the unstable PPA version of
nvimis linked against Lua 5.1 (:lua print(_VERSION)), which does not have support forgoto. This pull request refactors that part of the code so that it shouldn't need agoto. Please let me know if there are further adjustments I need to make (or feel free to do them yourself in the interest of speed).