This repository was archived by the owner on Jul 6, 2021. It is now read-only.
Fix LspDiagnosticsChanged not firing#35
Merged
haorenW1025 merged 2 commits intonvim-lua:masterfrom Jun 30, 2020
ndreas:fix/diagnostics-changed-event
Merged
Fix LspDiagnosticsChanged not firing#35haorenW1025 merged 2 commits intonvim-lua:masterfrom ndreas:fix/diagnostics-changed-event
haorenW1025 merged 2 commits intonvim-lua:masterfrom
ndreas:fix/diagnostics-changed-event
Conversation
vim.schedule_wrap() returns a function that needs to be executed in order to schedule the actual execution of the function taken by schedule_wrap()
wbthomason
suggested changes
Jun 23, 2020
wbthomason
left a comment
wbthomason
left a comment
There was a problem hiding this comment.
I think the slight tweak to the changes I commented on would be good to make for code cleanliness and a (minuscule) performance improvement.
Contributor
Author
Much better, yes :) |
Collaborator
|
Oh sorry for not following these stuff here. This looks good for me. Thanks for the work:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a problem with
LspDiagnosticsChangednot firing, and traced it to the change in #21, and I dug a bit more and found the following:vim.schedule_wrap()returns a function that needs to be executed in order to schedule the actual execution of the function taken byschedule_wrap()