Conversation
Collaborator
|
I think overall I'm pretty happy with moving this over, and the way that you've done it. A few quick thoughts:
|
Conni2461
pushed a commit
to Conni2461/plenary.nvim
that referenced
this pull request
Aug 13, 2021
* feat: Move all of popup into plenary * fixup: Add lint that only certain plenary modules can be required * fixup: stylua * fixup: Update test to search for both types of requires * fixup: Add readme * fixup: Update readme
This was referenced Apr 3, 2023
Jint-lzxy
pushed a commit
to ayamir/nvimdots
that referenced
this pull request
Apr 3, 2023
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
Apr 3, 2023
boomker
pushed a commit
to boomker/uvcode-nvim
that referenced
this pull request
Apr 4, 2023
Ref: nvim-lua/plenary.nvim#209 (cherry picked from commit 7f1b6b0)
charliie-dev
referenced
this pull request
in charliie-dev/nvimdots.lua
Apr 6, 2023
YanTree
pushed a commit
to YanTree/nvim
that referenced
this pull request
Apr 9, 2023
|
@tjdevries I think you forgot to archive popup? nvim-lua/popup.nvim#24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plan is that we will deprecate (and then archive) nvim-lua/popup.nvim
There has been some confusion and overlap between the two plugins and this will make things simpler to manage and to keep them in sync. The end goal is still to upstream the work done in (now)
plenary.popup.@l-kershaw here is PR :)