Skip to content

fix(test_harness): kill job on timeout and check signal for failure on job completion#388

Merged
Conni2461 merged 2 commits intonvim-lua:masterfrom
williamboman:fix/check-signal
Sep 3, 2022
Merged

fix(test_harness): kill job on timeout and check signal for failure on job completion#388
Conni2461 merged 2 commits intonvim-lua:masterfrom
williamboman:fix/check-signal

Conversation

@williamboman
Copy link
Copy Markdown
Contributor

@williamboman williamboman commented Jul 22, 2022

This is to catch test runs where the process exits erroneously, for
example via a SIGABRT.

I also noticed that spawned jobs are not terminated should the test time out.

This is to catch test runs where the process exits erroneously, for
example via a SIGABRT.
@williamboman williamboman changed the title fix(test_harness): also check signal on job completion fix(test_harness): kill job on timeout and check signal for failure on job completion Jul 22, 2022
Copy link
Copy Markdown
Collaborator

@Conni2461 Conni2461 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants