fix(log): no file made if no cache dir#392
Merged
Conni2461 merged 1 commit intonvim-lua:masterfrom Aug 1, 2022
Merged
Conversation
On Neovim nightly (currently pre `v0.8`), the log file cannot be created and writen to since the `.cache/nvim` directory is not created. This is fixed by checking that the parent of the outfile does not exist and if it doesn't creating the directory, as mentioned by @Conni2461. Fixes: nvim-luaGH-367 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
filipdutescu
force-pushed
the
fix/cache_directory_not_created
branch
from
ad535aa to
0247e24
Compare
Collaborator
|
LGTM thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Neovim nightly (currently pre
v0.8), the log file cannot be createdand writen to since the
.cache/nvimdirectory is not created. This isfixed by checking that the parent of the outfile does not exist and if
it doesn't creating the directory, as mentioned by @Conni2461.
Fixes: GH-367
Signed-off-by: Filip Dutescu filip.dutescu@gmail.com