Check for metatable with __call when asserting callable status#396
Merged
Conni2461 merged 1 commit intonvim-lua:masterfrom Sep 3, 2022
Merged
Check for metatable with __call when asserting callable status#396Conni2461 merged 1 commit intonvim-lua:masterfrom
__call when asserting callable status#396Conni2461 merged 1 commit intonvim-lua:masterfrom
Conversation
Conni2461
reviewed
Aug 12, 2022
Conni2461
reviewed
Aug 12, 2022
krady21
force-pushed
the
fix-assert-callable-async
branch
2 times, most recently
from
4265006 to
5983f6f
Compare
Collaborator
|
Sorry for the late response, i was on vacation. The tests seem now to run but you still need to update the code to follow our styling config. See failing job. Thanks for the PR :) After that is fixed, ill merge this PR :) |
krady21
force-pushed
the
fix-assert-callable-async
branch
from
5983f6f to
16d8e2f
Compare
|
Is there any workaround until then? |
Conni2461
approved these changes
Sep 3, 2022
Collaborator
Conni2461
left a comment
Conni2461
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while trying to wrap() the vim.ui.input offered by dressing.nvim, as it actually overrides the value with a table that implements
__callinstead of an actual function.