Skip to content

Conversation

@habeebweeb
Copy link
Contributor

unnamedplus is never resolved because it already contains unnamed.

@echasnovski
Copy link
Member

Thanks for the PR!

I can indeed reproduce the issue with current implementation but am having hard time converting it to the test. Will incorporate this soon.

echasnovski added a commit that referenced this pull request Aug 18, 2023
Details:
- Resolves #443.

Co-authored-by: habeebweeb <40900143+habeebweeb@users.noreply.github.com>
@echasnovski
Copy link
Member

Thanks for noticing this. It should now by fixed on main branch.

@habeebweeb
Copy link
Contributor Author

Thank you for your work. It seems the commit was tagged with (mini.operators). Hopefully that doesn't cause any issues.

echasnovski added a commit that referenced this pull request Aug 18, 2023
Details:
- Resolves #443.

Co-authored-by: habeebweeb <40900143+habeebweeb@users.noreply.github.com>
@echasnovski
Copy link
Member

Thank you for your work. It seems the commit was tagged with (mini.operators). Hopefully that doesn't cause any issues.

Oops! Thanks for noticing. Hope force push after 12 minutes won't break many configs :)

@habeebweeb habeebweeb deleted the fix_get_default_register branch August 18, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants