Skip to content

fix(ui): resolve linked highlight groups #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

fix(ui): resolve linked highlight groups #1929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lua/neo-tree/ui/highlights.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ end
---@param name string
local get_hl_by_name = function(name)
if vim.api.nvim_get_hl then
local hl = vim.api.nvim_get_hl(0, { name = name })
local hl = vim.api.nvim_get_hl(0, { name = name, link = false })
---@diagnostic disable-next-line: inject-field
hl.foreground = hl.fg
---@diagnostic disable-next-line: inject-field
Expand All @@ -88,10 +88,10 @@ end
---@param gui string? The gui to use, if the highlight group is not defined and it is not linked to another group.
---@return table hlgroups The highlight group values.
M.create_highlight_group = function(hl_group_name, link_to_if_exists, background, foreground, gui)
local success, hl_group = pcall(get_hl_by_name, hl_group_name, true)
local success, hl_group = pcall(get_hl_by_name, hl_group_name)
if not success or not hl_group.foreground or not hl_group.background then
for _, link_to in ipairs(link_to_if_exists) do
success, hl_group = pcall(get_hl_by_name, link_to, true)
success, hl_group = pcall(get_hl_by_name, link_to)
if success then
local new_group_has_settings = background or foreground or gui
local link_to_has_settings = hl_group.foreground or hl_group.background
Expand Down