feat(agenda): highlight upcoming deadlines as @org.agenda.deadline.upcoming#1138
Merged
Merged
Conversation
…pcoming` AI-assisted: Claude Sonnet 4.6 from GitHub Copilot
Contributor
Author
|
Thanks for your quick response! As mentioned above, I'd suggest to:
I'd like to know your opinions on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-assisted: Claude Sonnet 4.6 from GitHub Copilot
Summary
Added
@org.agenda.deadline.upcomingfor upcoming deadlines, especially for the deadline items shown at today.Before:
After: Upcoming deadline items shown at today are no longer highlighted as
scheduled_past.Related Issues
Closes #1137
Changes
@org.agenda.deadline.upcomingdefaults to the same style as@org.agenda.scheduled_pastlua/orgmode/colors/highlights.lualua/orgmode/colors/init.lualua/orgmode/agenda/agenda_item.luaagenda/agenda_item_spec.luaandcolor/color_specs.luato use the new highlight nameNotes:
I updated the tests yet when I do
make test, there're some not passing but unrelated to this MR.Also I'd suggest to change
...scheduled_pastto...scheduled.past, and make it clearer in the code, that is to stop usingwarningand use the highlight names directly.Checklist
I confirm that I have:
Conventional Commits
specification (e.g.,
feat: add new feature,fix: correct bug,docs: update documentation).make test.