Skip to content

add argument of changing readonly and modified icon.#116

Merged
glepnir merged 1 commit intonvimdev:mainfrom
ya2s:main
Mar 31, 2021
Merged

add argument of changing readonly and modified icon.#116
glepnir merged 1 commit intonvimdev:mainfrom
ya2s:main

Conversation

@ya2s
Copy link
Copy Markdown
Contributor

@ya2s ya2s commented Mar 18, 2021

Description

add argument of changing readonly and modified icon.

Type of change

  • New feature (non-breaking change which adds functionality)

Reference

@gegoune
Copy link
Copy Markdown

gegoune commented Mar 18, 2021

It would be good to add some documentation. Otherwise discoverability of this feature won't be too good.

@ya2s
Copy link
Copy Markdown
Contributor Author

ya2s commented Mar 19, 2021

Is the document added to the readme?
The following functions are also not described.
https://github.com/glepnir/galaxyline.nvim/blob/a6c2cbc2218cb2e59fd3353fb827da82b84a248a/lua/galaxyline/provider_extensions.lua#L28
Isn't it unnatural that there is only one explanation for the function?

@glepnir
Copy link
Copy Markdown
Member

glepnir commented Mar 19, 2021

vista_nearest already in readme.

@glepnir
Copy link
Copy Markdown
Member

glepnir commented Mar 19, 2021

about this change. I think it's better to add description in readme.

@ya2s
Copy link
Copy Markdown
Contributor Author

ya2s commented Mar 19, 2021

vista_nearest already in readme.

There is a description, but there is no details about vista_icon.
So get_current_file_name is already listed in the readme.

if add, I think should give details about all the functions you provide.

@ya2s
Copy link
Copy Markdown
Contributor Author

ya2s commented Mar 31, 2021

@glepnir
Can you give me a review?

@glepnir
Copy link
Copy Markdown
Member

glepnir commented Mar 31, 2021

LGTM

@glepnir glepnir merged commit a7d6cea into nvimdev:main Mar 31, 2021
@WhyNotHugo
Copy link
Copy Markdown

How is modified_icon used? E.g.: How do I provide this parameter?

I agree on the comments here that this should be mentioned in the README, even looking at the source I can't quite figure out how to provide this parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants