Skip to content

feat: add npm-groovy-lint, jq, yamlfmt, yamlfix, xmllint formatters#49

Merged
xiaoshihou514 merged 4 commits intonvimdev:mainfrom
231tr0n:main
Dec 8, 2024
Merged

feat: add npm-groovy-lint, jq, yamlfmt, yamlfix, xmllint formatters#49
xiaoshihou514 merged 4 commits intonvimdev:mainfrom
231tr0n:main

Conversation

@231tr0n
Copy link
Copy Markdown
Contributor

@231tr0n 231tr0n commented Dec 8, 2024

Checklist (adding a new tool):

  • If it's a linter it was exported in linter/init.lua
  • The tool was added to the README
  • I do not wish to write a test, but I can confirm that it works on my machine OR I have written corresponding tests for the tools I added. (don't worry if you didn't write a test, it's just nice to see the green check mark)

This PR also closes #38

@xiaoshihou514
Copy link
Copy Markdown
Member

I am not sure about the jq config, shouldn't jq . do the trick?

@231tr0n
Copy link
Copy Markdown
Contributor Author

231tr0n commented Dec 8, 2024

@xiaoshihou514 I actually tested it and it works. You can do it like this as well cat somefile.json | jq -M

@xiaoshihou514
Copy link
Copy Markdown
Member

Yes, but do we really need this flag

@231tr0n
Copy link
Copy Markdown
Contributor Author

231tr0n commented Dec 8, 2024

Yes, but do we really need this flag

It outputs colors without that flag. So we might end up having terminal escape characters for colors afaik. I did not test it though without the -M flag.

@xiaoshihou514
Copy link
Copy Markdown
Member

By default, jq outputs colored JSON if writing to a terminal. You can force it to produce color even if writing to a pipe or a file using -C

@231tr0n
Copy link
Copy Markdown
Contributor Author

231tr0n commented Dec 8, 2024

Ohh it works like that is it, ok then should i remove the -M flag then?

@xiaoshihou514
Copy link
Copy Markdown
Member

I have no experience with other tools, so they look good to me.

@xiaoshihou514
Copy link
Copy Markdown
Member

Ohh it works like that is it, ok then should i remove the -M flag then?

Yes

@231tr0n
Copy link
Copy Markdown
Contributor Author

231tr0n commented Dec 8, 2024

@xiaoshihou514! done removed it.

@xiaoshihou514 xiaoshihou514 merged commit 716d7ee into nvimdev:main Dec 8, 2024
@xiaoshihou514
Copy link
Copy Markdown
Member

Thanks for the pr btw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for eslint flat configuration

2 participants