fix(lib/highlight): Ignore invalid highlight keys#18
Merged
benlubas merged 2 commits intonvimtools:mainfrom Jan 1, 2024
Merged
fix(lib/highlight): Ignore invalid highlight keys#18benlubas merged 2 commits intonvimtools:mainfrom
benlubas merged 2 commits intonvimtools:mainfrom
Conversation
If a user sets colour scheme to default after Neovim starts,
nvim_get_hl_by_name('HydraRed', true) returns { [true] = 6 }. This
causes an 'invalid key' error later when it's used in nvim_set_hl().
It is quite a rare case, and it should be fine as long as we can avoid
the error, so that Hydra still functions.
benlubas
approved these changes
Dec 31, 2023
benlubas
requested changes
Dec 31, 2023
Collaborator
benlubas
left a comment
benlubas
left a comment
There was a problem hiding this comment.
could we switch to the new api function nvim_get_hl
Collaborator
|
@Frederick888 I'm unable to reproduce the issue as described in the original issue you linked, but I didn't have to do any of the key checks that you had to do (b/c we're using the new api) Can you make sure that this branch works and then I can go ahead and merge this |
Contributor
Author
|
@benlubas Yes, I can confirm this branch works. Thank you. |
benlubas
approved these changes
Jan 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user sets colour scheme to default after Neovim starts,
nvim_get_hl_by_name('HydraRed', true) returns { [true] = 6 }. This
causes an 'invalid key' error later when it's used in nvim_set_hl().
It is quite a rare case, and it should be fine as long as we can avoid
the error, so that Hydra still functions.
This was anuvyklack/hydra.nvim#75